Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing my testimonial #3536

Merged
merged 3 commits into from
Mar 7, 2019
Merged

Removing my testimonial #3536

merged 3 commits into from
Mar 7, 2019

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Feb 13, 2019

I'm worried that my testimonial would encourage users of pip to switch to pipenv without fully diving into the subtle differences to the venv+pip development workflow they may be used to. Since I've signed the statement with "former pip maintainer" this can in particular create frustrations to users and lead to wrong expectations.

I'm worried that my testimonial would encourage users of pip to switch to pipenv without fully diving into the subtle differences to the venv+pip development workflow they may be used to. Since I've signed the statement with "former pip maintainer" this can in particular create frustrations to users and lead to wrong expectations.
@ghost ghost mentioned this pull request Mar 3, 2019
2 tasks
@frostming frostming added the PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge. label Mar 7, 2019
@techalchemy
Copy link
Member

@jezdez happy to remove this if you like, I'd encourage you to try out the master branch and suggest other ways to help with that clarification if you think this remains a point of confusion. We push back pretty strongly against that idea and work closely with the pip maintainers to try and track shared logic so we can work out a path forward for merging code where applicable.

Pip isn't going anywhere. It's a lot more likely that a bunch of our logic will get incorporated into pip and some shared logic will get refactored out of both places.

@frostming frostming merged commit e2738a8 into pypa:master Mar 7, 2019
@jezdez
Copy link
Member Author

jezdez commented Mar 7, 2019

@techalchemy Thank you for merging @frostming!

FWIW I really appreciate everyone's work on pipenv and want to stress that removing the testimonial is no indicator for my personal interest in pipenv as a project nor anyone's work here. Keep up the great work you're doing!

@jezdez jezdez deleted the patch-2 branch March 7, 2019 09:24
jezdez added a commit to jezdez/pipenv that referenced this pull request Nov 12, 2019
Not sure what went wrong in pypa#3536.
@jezdez jezdez mentioned this pull request Nov 12, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants